Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screengrab exit_on_test_failure have is_string: false #7981

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

mfurtak
Copy link
Contributor

@mfurtak mfurtak commented Jan 24, 2017

This is the most correct way of describing a boolean option right now.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Without describing a boolean option as is_string: false, some weirdness can happen with the value coercions.

This is the most correct way of describing a boolean
option right now.
Copy link
Contributor

@ohayon ohayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfurtak mfurtak changed the title Make exit_on_test_failure have is_string: false Make screengrab exit_on_test_failure have is_string: false Jan 24, 2017
@gersonmdesouza
Copy link
Contributor

@mfurtak Nice!

@mfurtak mfurtak merged commit 584465b into master Jan 24, 2017
@mfurtak mfurtak deleted the screengrab-option-is-string branch January 24, 2017 21:37
@KrauseFx KrauseFx mentioned this pull request Jan 24, 2017
@fastlane fastlane locked and limited conversation to collaborators Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants