[sigh] Fix shell script quoting issue - follow up #7982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjanuschka
approved these changes
Jan 24, 2017
|
@asfalcone Thanks for picking it up! |
|
To be confident (this time) I ran the script on our main app, which has both embedded apps and extensions, as well as embedded Swift frameworks. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7971 (follow up)
Unnecessary quotes around
${KEYCHAIN_FLAG}were causing an issueinstead of passing to
codesignas--keychain $KEYCHAIN_PATHit was passed as"--keychain $KEYCHAIN_PATH"causing an issue.An unfortunate side-effect of fixing shellcheck issues.
I have revisited all other changes in that shellcheck update and ran resigning to make sure it works.