Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support iphone SE on screenshot collection #7995

Merged
merged 1 commit into from
Jan 25, 2017
Merged

support iphone SE on screenshot collection #7995

merged 1 commit into from
Jan 25, 2017

Conversation

hjanuschka
Copy link
Collaborator

@hjanuschka hjanuschka commented Jan 25, 2017 •
edited

issue: #6690

@hjanuschka hjanuschka mentioned this pull request Jan 25, 2017
Closed
NicosKaralis
NicosKaralis approved these changes Jan 25, 2017
View reviewed changes
Copy link

@NicosKaralis NicosKaralis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, it just adds the iPhone SE to the list of available devices to generate the screenshots html page

ohayon
ohayon approved these changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@ohayon ohayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjanuschka hjanuschka merged commit 8d08503 into master Jan 25, 2017
@KrauseFx KrauseFx deleted the hjanuschka-patch-1 branch January 25, 2017 18:15
@KrauseFx KrauseFx mentioned this pull request Jan 26, 2017
Merged
@Redysz Redysz mentioned this pull request Feb 2, 2017
Closed
@fastlane fastlane locked and limited conversation to collaborators Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicosKaralis NicosKaralis NicosKaralis approved these changes

@ohayon ohayon ohayon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hjanuschka @NicosKaralis @ohayon