Fastlane require format non plugins with dash #7998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thanks @joshdholtz !! 馃殌 |
Merged
lacostej
reviewed
Jan 27, 2017
|
|
||
| def format_gem_require_name(gem_name) | ||
| # from "fastlane-plugin-xcversion" to "fastlane/plugin/xcversion" | ||
| gem_name = gem_name.tr("-", "/") if gem_name.start_with? "fastlane-plugin-" |
There was a problem hiding this comment.
Would replace "fastlane/plugin/" to "fastlane-plugin-" be more portable? E.g. if the plugin name has a dash in it?
There was a problem hiding this comment.
Ahhh, good call good call - that is probably a lot safer. @ohwutup, i think you mentioned you did work on the initial plugin stuff. Is this a better way of doing it? ^
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7502
fastlane_require "rest-client"was formattingrest-clientasrest/clientwas causing a 馃挜The comment above that logic was saying that replacing of
-with/was specifically forfastlane-plugin-so now the logic inside offastlane_requireonly replaces-with/if it starts withfastlane-plugin-馃殌