Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip_testing, only_testing options to scan #8002

Merged
merged 3 commits into from
Jan 25, 2017
Merged

Add skip_testing, only_testing options to scan #8002

merged 3 commits into from
Jan 25, 2017

Conversation

mfurtak
Copy link
Contributor

@mfurtak mfurtak commented Jan 25, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

Carrying forward work from #7601

This PR adds options to Scan to specify specific test bundles/test suites/test cases to be run using the new -only-testing and -skip-testing options in Xcode 8's version of xcodebuild. More info on the actions can be found in the wwdc talk on Advanced Testing and Continuous Integration

This will need a follow-up to add information to the documentation for scan

@mfurtak mfurtak changed the title WIP - Add skip_testing, only_testing options to scan Add skip_testing, only_testing options to scan Jan 25, 2017
ohayon
ohayon reviewed Jan 25, 2017
View reviewed changes
Copy link
Contributor

@ohayon ohayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

scan/lib/scan/options.rb
def self.verify_type(item_name, acceptable_types, value)
type_ok = [Array, String].any? { |type| value.kind_of?(type) }
UI.user_error!("'#{item_name}' should be of type #{acceptable_types.join(' or ')} but found: #{value.class.name}") unless type_ok
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

ohayon
ohayon approved these changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@ohayon ohayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfurtak mfurtak merged commit b7d6ee6 into master Jan 25, 2017
@mfurtak mfurtak deleted the scan-skip-only-testing-options branch January 25, 2017 20:24
This was referenced Jan 25, 2017
Closed
Closed
@KrauseFx KrauseFx mentioned this pull request Jan 26, 2017
Merged
@Redysz Redysz mentioned this pull request Feb 2, 2017
Closed
@fastlane fastlane locked and limited conversation to collaborators Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ohayon ohayon ohayon approved these changes

Assignees
No one assigned
Labels
tool: scan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mfurtak @ohayon