Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scan error message for bad SLACK_URL #8004

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Conversation

mfurtak
Copy link
Contributor

@mfurtak mfurtak commented Jan 25, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

Improve error messaging when scan's SlackPoster gets a 404 back from Slack

Motivation and Context

When a SLACK_URL is given, but it is not quite right, people were seeing this error message in their scan run logs. It's rather impossible to know what to do with this message.

[16:11:13]: ▸ Test Succeeded
[16:11:13]: #<Net::HTTPNotFound:0x007f93332e8df8>

This PR changes the error message in this case to be:

[16:15:18]: ▸ Test Succeeded
[16:15:19]: The Slack URL you provided (https://hooks.slack.com/services/XXX/XXX/XXX) could not be reached (404)

@mfurtak mfurtak merged commit 5cfef13 into master Jan 25, 2017
@mfurtak mfurtak deleted the improve-slack-error branch January 25, 2017 21:30
@hjanuschka
Copy link
Collaborator

such a great find 💯

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful 👍 Nice find

@KrauseFx KrauseFx mentioned this pull request Jan 26, 2017
@fastlane fastlane locked and limited conversation to collaborators Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants