[fastlane] local actions should be imported before their Fastfile otherwise importing the Fastfile might fail #8080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
force-pushed
the
imported_root_actions
branch
from
5c95ef8
to
b5f2194
Compare
…erwise importing the Fastfile might fail
lacostej
force-pushed
the
imported_root_actions
branch
from
71f230c
to
71a155b
Compare
KrauseFx
approved these changes
Feb 2, 2017
KrauseFx
reviewed
Feb 2, 2017
| end | ||
|
|
||
| def self.authors | ||
| ["lacostej/jerome@wewanttoknow.com"] |
There was a problem hiding this comment.
Just the username should be good enough
|
This makes lots of sense, thanks for this. Have you tested if the tests fail when you revert the actual change? |
|
@KrauseFx yes I started writing the test first then squashed. Next time I push separately so you get the circleci failure first if you prefer. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.