[CI] Cache dependencies #8200
Merged
[CI] Cache dependencies #8200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
force-pushed
the
dani_ci_cleanup
branch
7 times, most recently
from
e1f7c57
to
8f3f2c7
Compare
KrauseFx
reviewed
Feb 11, 2017
fastlane/Fastfile
Outdated
| ensure_no_debug_code(text: "now: ", extension: ".rb") # rspec focus | ||
| ensure_no_debug_code(text: "<<<<<<<", extension: ".rb") # Merge conflict | ||
| ensure_no_debug_code(text: "binding.pry", extension: ".rb", exclude: "(.bundle/**/*.rb|**/*/playground.rb)") # debugging code | ||
| ensure_no_debug_code(text: "# TODO", extension: ".rb", exclude: "\*/.bundle*") # TODOs |
There was a problem hiding this comment.
Should we install the bundler in a root directory, so that it's not included by default when searching through files?
There was a problem hiding this comment.
@KrauseFx Sadly, ensure_no_debug_code runs in the context of the checkout root, not of the fastlane module. And installing out of that tree is kinda liable to breakages if the environment changes.
endocrimes
force-pushed
the
dani_ci_cleanup
branch
from
8f3f2c7
to
62f192a
Compare
Generated by 🚫 Danger |
Install bundle to `.bundle` to allow for CI caching.
endocrimes
force-pushed
the
dani_ci_cleanup
branch
from
eb3dd9a
to
f76423c
Compare
KrauseFx
approved these changes
Feb 12, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CI configuration to install gems into the
.bundledirectory. This allows the installed gems to be cached to avoid fetching them from Rubygems on every build. It also changesbundle installcalls to first invokebundle check. Together this should save 10 - 30 seconds from every CI build, potentially more when the network is slow.