Refactor pilot CommanderGenerator usage #8287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carry the work and lessons learned from #8129 over to pilot pilot does not currently have any option conflicts, but this refactoring is still generally more correct and safe.
hjanuschka
approved these changes
Feb 17, 2017
mfurtak
pushed a commit
that referenced
this pull request
Feb 18, 2017
Carry the work and lessons learned from #8129 over to produce produce does not currently have any option conflicts, but this refactoring is still generally more correct and safe.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validDescription
Carry the work and lessons learned from #8129 over to pilot
Motivation and Context
pilot does not currently have any option conflicts, but this refactoring is still generally more correct and safe.