Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'fastlane env' not to crash when Xcode Version cannot be obtained #8301

Merged
merged 1 commit into from Feb 19, 2017

Conversation

nafu
Copy link
Collaborator

@nafu nafu commented Feb 19, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

Fix fastlane env not to crash when Xcode Version cannot be obtained

Motivation and Context

If Xcode Version cannot be obtained, fastlane env crashes and the user cannot get any output of fastlane environment.
e.x. #8187 (comment)

Copy link
Contributor

@mfurtak mfurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🚀

@mfurtak mfurtak merged commit a76d95b into fastlane:master Feb 19, 2017
@nafu nafu deleted the fix-fastlane-env-crash branch February 20, 2017 00:33
@fastlane fastlane locked and limited conversation to collaborators May 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants