Fix error installing the AppleWWDRCA certificate on multiuser systems #8509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @mcfedr, this looks like a good change. Currently these changes are causing the tests to break. If you could make sure that the tests are passing we will be able to get this merged in! 🐙 |
|
@ohayon yea, ill look at that, rspec didnt want to run locally so i pushed and hoped :) |
mcfedr
force-pushed
the
apple_wwdrca_multiuser
branch
from
783afaa
to
f2086b1
Compare
It can happen that the file /tmp/AppleWWDRCA.cer already exists, this causes the install to fail because the file cannot be created as the current user. Using a random temp file prevents this issue
mcfedr
force-pushed
the
apple_wwdrca_multiuser
branch
from
f2086b1
to
a2e23b6
Compare
|
@giginet All greened up! |
hjanuschka
approved these changes
Mar 17, 2017
Merged
|
Congratulations! 🎉 This was released as part of fastlane 2.21.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validDescription
Download AppleWWDRCA.cer as a Tempfile rather than to a specific filename.
Using Tempfile also means that ruby automatically removes the file from the system.
Motivation and Context
It can happen that the file /tmp/AppleWWDRCA.cer already exists, this
causes the install to fail because the file cannot be created as the
current user. Using a random temp file prevents this issue.
This happens on my CI server, which is a single mac with multiple users as
separate runners, the first to create the file
/tmp/AppleWWDRCA.cerworks,all the other runners fail to run
match.