Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'associated_groups' attribute to Spaceship::Portal::App #8516

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Add 'associated_groups' attribute to Spaceship::Portal::App #8516

merged 2 commits into from
Mar 17, 2017

Conversation

xai3
Copy link
Contributor

@xai3 xai3 commented Mar 14, 2017 •
edited

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

getAppIdDetail.action API returns the associatedApplicationGroups element.
So I added the associated_groups attribute to Spaceship::Portal::App class.

Motivation and Context

#8508
#8143

@xai3 xai3 changed the title Feature/get associated group from app Add 'associated_groups' attribute to Spaceship::Portal::App Mar 14, 2017
@xai3
Copy link
Contributor Author

xai3 commented Mar 15, 2017

I signed it!

@hjanuschka
Copy link
Collaborator

thx - cool PR 🚀

@hjanuschka hjanuschka merged commit 3a2b40f into fastlane:master Mar 17, 2017
@nafu
Copy link
Collaborator

nafu commented Mar 17, 2017

@YukiAsai @hjanuschka 🚀

@xai3
Copy link
Contributor Author

xai3 commented Mar 17, 2017

@hjanuschka @nafu thank you for reviewing 👍

@KrauseFx KrauseFx mentioned this pull request Mar 20, 2017
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.21.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hjanuschka hjanuschka hjanuschka approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xai3 @hjanuschka @nafu @fastlane-bot @googlebot