Ignore newline of demo user information

[giginet]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Description

Ignore newline string of demo_user and demo_password of review information.

And use this opportunity to increase code coverage of upload_metadata.

Motivation and Context

If demo_user or demo_password contains newline(\n), review_user_needed become true and following error is raised from iTunes Connect.

[!] The request could not be completed because:
        Enter a demo account user name. Enter a demo account password.

So it ignores newline of metadata/app_review_information/demo_user and metadata/app_review_information/demo_password

[KrauseFx]

This looks great to me. Have you ensured that the tests are failing without the newly added chomp? 👍

[giginet]

The tests are failing without the newly added chomp?

I checked this then the tests are failed.

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.21.0 🚀