Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change or generate README.md after running rspec #8629

Merged
merged 6 commits into from
Apr 1, 2017
Merged

Do not change or generate README.md after running rspec #8629

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d19fdd
Do not change or generate README.md after running rspec
nafu Mar 23, 2017
126cb53
Mock FastlaneCore::Env to skip generating docs
nafu Mar 24, 2017
edf4a84
Do not change existing code in lane_manager_spec
nafu Mar 24, 2017
8f0f698
Feedback addressed
nafu Mar 26, 2017
07be685
Fix rubocop error by extracting method
nafu Mar 28, 2017
4bc418c
Merge branch 'master' into remove-readme-after-run-rspec
nafu Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion fastlane/lib/fastlane/lane_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def self.cruise_lane(platform, lane, parameters = nil, env = nil)
end

# After running the lanes, since skip_docs might be somewhere in-between
Fastlane::DocsGenerator.run(ff) unless FastlaneCore::Env.truthy?("FASTLANE_SKIP_DOCS")
Fastlane::DocsGenerator.run(ff) unless skip_docs?

duration = ((Time.now - started) / 60.0).round

Expand All @@ -70,6 +70,10 @@ def self.cruise_lane(platform, lane, parameters = nil, env = nil)
return ff
end

def self.skip_docs?
Helper.test? || FastlaneCore::Env.truthy?("FASTLANE_SKIP_DOCS")
end

# All the finishing up that needs to be done
def self.finish_fastlane(ff, duration, error)
ff.runner.did_finish
Expand Down