Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastlane tool collector to work with mono repo change #8632

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

KrauseFx
Copy link
Member

This fixes an issue where the version number of a sub tool wasn't properly recorded when calling fastlane scan ... after the mono-gem change

This fixes an issue where the version number of a sub tool wasn't properly recorded when calling `fastlane scan ...` after the mono-gem change
@KrauseFx
Copy link
Member Author

I was looking into how to add tests to this, however couldn't find a way to do so. We already have tests in https://github.com/fastlane/fastlane/blob/master/fastlane/spec/action_collector_spec.rb#L34-L37, and they're passing as they should, however they passed before.

The reason why the previous implementation wasn't correct is that when you call a tool with fastlane scan ... we might have never called require 'fastlane' and therefore don't have the actions loaded to check if it's a built-in action. It's safe to use the fastlane version as we're a mono-gem now, with the exception of plugins, where we want to load the actual plugin version.

I'd be ok with merging it as is, but if anybody has a better idea of how to add tests, I'm more than happy to update the PR. Basically this would require us to somehow unload the fastlane library I think

@mfurtak
Copy link
Contributor

mfurtak commented Mar 24, 2017

I think those existing specs cover this functionality well 👍

@KrauseFx KrauseFx merged commit 51b2286 into master Mar 24, 2017
@KrauseFx KrauseFx deleted the tool_collector branch March 24, 2017 17:42
@KrauseFx KrauseFx mentioned this pull request Mar 30, 2017
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.24.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jun 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants