Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the zip output path from relative to absolute #8637

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

xai3
Copy link
Contributor

@xai3 xai3 commented Mar 24, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

I changed the zip output path from relative path to absolute path.
Because zip action changes directory (via Dir.chidir) to ../params[:path] and trying to output to output_path by relative path from there.

Motivation and Context

#8620

Copy link
Contributor

@ohayon ohayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks @YukiAsai !! 🚀

@ohayon ohayon merged commit b530edf into fastlane:master Mar 24, 2017
@KrauseFx KrauseFx mentioned this pull request Mar 30, 2017
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.24.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jun 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants