Add skip_package_ipa option to Gym #8734
Conversation
Sometimes you don’t want an ipa but rather, just the xcarchive.
| FastlaneCore::ConfigItem.new(key: :skip_package_ipa, | ||
| env_name: "GYM_SKIP_PACKAGE_IPA", | ||
| description: "Should we skip packaging the ipa?", | ||
| is_string: false, |
There was a problem hiding this comment.
Should we have this be optional: true?
There was a problem hiding this comment.
I was thinking about that. Instead of optional, I just put default_value: false since having both seems a bit redundant.
I figure it's never optional if there is always a default_value
There was a problem hiding this comment.
I actually provided the opposite feedback, however both work: #8721
There was a problem hiding this comment.
NVM! Realized that there is the default_value: false there! 👍
|
Are there tests we can add to ensure that this stays working in the future? |
|
@mfurtak we currently don't have any tests for |
|
@mfurtak 🤔 |
|
I think I'd like to create a task to do the testing. It seems rather complicated to get the runner test up and running, and this is a trivial update. |
|
Do I understand it correctly, that now I can do something like this? gym(skip_packaging_ipa: true)
gym(archive_path: "<WHAT_TO_PUT_HERE?>", export_method: 'development')
gym(archive_path: "<WHAT_TO_PUT_HERE?>", export_method: 'app-store')And what to use instead of |
|
Hey @taquitos 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
added
status: included-in-next-release
and removed
status: needs-attention
labels
|
Congratulations! 🎉 This was released as part of fastlane 2.28.3 🚀 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
|
I am sorry to be annoying, but do somebody know the answer to my question (few posts above) please? :-) |
|
@EskiMag Please ask questions by submitting a new issue for this repo. Also, it seems like your question is not related to this PR. |
Sometimes you don’t want an ipa but rather, just the xcarchive.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validDescription
Add skip_package_ipa option to Gym so after building the xcarchive we don't try to package up the ipa. Gym will return the path to the archive.
Motivation and Context
Some company build systems don't give access to certificates and they want to package up an ipa their way. This way you can output an xcarchive and hand it off to the internal build system.