Use the new UI.test_failure! in screengrab #8736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new UI.test_failure! in screengrab to handle test failures to get the better success/ failure semantics introduced in #8631
KrauseFx
reviewed
Mar 31, 2017
| UI.user_error!("Tests failed", show_github_issues: false) if test_output.include?("FAILURES!!!") | ||
| else | ||
| UI.error("Tests failed") if test_output.include?("FAILURES!!!") | ||
| if test_output.include?("FAILURES!!!") |
KrauseFx
approved these changes
Mar 31, 2017
asfalcone
approved these changes
Mar 31, 2017
|
Hey @mfurtak 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Merged
|
Congratulations! 🎉 This was released as part of fastlane 2.25.0 🚀 |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validDescription
Use the new
UI.test_failure!in screengrab to handle test failuresMotivation and Context
To get the better success/failure semantics introduced in #8631