New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Ipa package in random tmpdir #8748
Conversation
Hey @mcfedr, thanks for the PR! Just to clarify your motivation for this: are you looking to run the build as one user and then complete the pilot upload as another user on the same machine? Thanks! 🐙 |
Hi, @ohayon . I have a CI machine, with several users each running a gitlab-runner so they can run concurrently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great change that makes sense for sure. However fastlane and xcodebuild doesn't allow running multiple instances afaik, so make sure to test everything
Have you tested this on your local machine? |
To clarify: because you can only run one simulator per machine/user make sure that everything works. fastlane itself might have problems running multiple times at the same time |
Yes, I have tested it on my local machine and on my CI server, and it solves the problem I was having. |
Awesome, thanks @mcfedr 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.25.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validDescription
Don't put the ipa upload package just in
/tmp
, put justmktmpdir
to make a unique temp name.Motivation and Context
On a multiuser system, one user creates the package, then pilot will fail for other users because it cannot read/write to the file.