Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ipa package in random tmpdir #8748

Merged
merged 1 commit into from Apr 3, 2017

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Apr 3, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

Don't put the ipa upload package just in /tmp, put just mktmpdir to make a unique temp name.

Motivation and Context

On a multiuser system, one user creates the package, then pilot will fail for other users because it cannot read/write to the file.

@ohayon
Copy link
Contributor

ohayon commented Apr 3, 2017

Hey @mcfedr, thanks for the PR! Just to clarify your motivation for this: are you looking to run the build as one user and then complete the pilot upload as another user on the same machine? Thanks! 🐙

@mcfedr
Copy link
Contributor Author

mcfedr commented Apr 3, 2017

Hi, @ohayon . I have a CI machine, with several users each running a gitlab-runner so they can run concurrently.

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great change that makes sense for sure. However fastlane and xcodebuild doesn't allow running multiple instances afaik, so make sure to test everything

@KrauseFx
Copy link
Member

KrauseFx commented Apr 3, 2017

Have you tested this on your local machine?

@KrauseFx
Copy link
Member

KrauseFx commented Apr 3, 2017

To clarify: because you can only run one simulator per machine/user make sure that everything works. fastlane itself might have problems running multiple times at the same time

@mcfedr
Copy link
Contributor Author

mcfedr commented Apr 3, 2017

Yes, I have tested it on my local machine and on my CI server, and it solves the problem I was having.
Yes, only one of the users on the CI machine can run the simulator, one account runs in a UI session and the other runners can just do builds without running tests.

@KrauseFx KrauseFx merged commit adadf04 into fastlane:master Apr 3, 2017
@KrauseFx
Copy link
Member

KrauseFx commented Apr 3, 2017

Awesome, thanks @mcfedr 👍

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.25.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants