Pin the rubocop version to prevent reactive fixing #8753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because any new version of rubocop could introduce new rules, letting the version number float adds a lot of reactive fixing for us. Pinning the version number will let us decide when we want to take on new style changes.
asfalcone
approved these changes
Apr 3, 2017
endocrimes
approved these changes
Apr 3, 2017
KrauseFx
reviewed
Apr 3, 2017
Merged
|
Congratulations! 🎉 This was released as part of fastlane 2.25.0 🚀 |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validDescription
Because any new version of rubocop could introduce new rules, letting the version number float adds a lot of reactive fixing for us.
Pinning the version number will let us decide when we want to take on new style changes.