Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in match #8757

Merged
merged 2 commits into from Apr 3, 2017
Merged

Fix typo in match #8757

merged 2 commits into from Apr 3, 2017

Conversation

colorbox
Copy link
Contributor

@colorbox colorbox commented Apr 3, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines

Description

fix typo in match/generator and match/runner

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks 👍

@KrauseFx
Copy link
Member

KrauseFx commented Apr 3, 2017

Please follow the instructions from the bot so we can merge the changes 👍

@colorbox
Copy link
Contributor Author

colorbox commented Apr 3, 2017

I signed CLA. 😃

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 3, 2017
@hjanuschka hjanuschka merged commit 9374648 into fastlane:master Apr 3, 2017
@colorbox colorbox deleted the fix-typo-in-match branch April 4, 2017 00:38
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.25.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants