Fix LoadError catching when it's not related to CommandsGenerator #8831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rescue `LoadError` so that we tell users to run the tool directly if CommandsGenerator is not available. However since we call `.start` inside that `begin` `rescue` block we'd catch all LoadErrors from within fastlane, and then show the confusing error message of ``` pilot can't be called via `fastlane pilot`, run 'pilot' directly instead ```
taquitos
approved these changes
Apr 8, 2017
| @@ -48,13 +48,14 @@ def take_off | |||
| require File.join(tool_name, "commands_generator") | |||
|
|
|||
| # Call the tool's CommandsGenerator class and let it do its thing | |||
| Object.const_get(tool_name.fastlane_module)::CommandsGenerator.start | |||
| commands_generator_ref = Object.const_get(tool_name.fastlane_module)::CommandsGenerator | |||
There was a problem hiding this comment.
nit: adding "_ref" seems redundant
|
Hey @KrauseFx 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
|
Congratulations! 🎉 This was released as part of fastlane 2.27.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rescue
LoadErrorso that we tell users to run the tool directly if CommandsGenerator is not available. However since we call.startinside thatbeginrescueblock we'd catch all LoadErrors from within fastlane, and then show the confusing error message of