Add support for app-level test_info #9055
Conversation
So that we can set beta_app_feedback_email and beta_app_description
| # for an application. Note that this structure, although looking similar to build test_info | ||
| # is test information about the application | ||
|
|
||
| attr_accessor :test_info |
There was a problem hiding this comment.
Why does a test info object have a test_info attribute?
|
Looks awesome. What's the easiest way to test it on a production system? As part of pilot, right? |
… set app info first.
|
@KrauseFx I wrote a RakeFile to test it, but yeah, easiest way is to run from |
pilot/lib/pilot/build_manager.rb
Outdated
| rescue => ex | ||
| UI.user_error!("Could not set changelog: #{ex}") | ||
| end | ||
| UI.success "Successfully set the changelog for build" |
There was a problem hiding this comment.
I think this might be nicer in the begin block.
pilot/lib/pilot/build_manager.rb
Outdated
| if should_update_app_test_information(options) | ||
| app_test_info = Spaceship::TestFlight::AppTestInfo.find(app_id: build.app_id) | ||
| app_test_info.test_info.feedback_email = options[:beta_app_feedback_email] if options[:beta_app_feedback_email] | ||
| app_test_info.test_info.description = options[:beta_app_description] if options[:beta_app_description] | ||
| app_test_info.save_for_app(app_id: build.app_id) | ||
| begin | ||
| app_test_info.save_for_app(app_id: build.app_id) |
There was a problem hiding this comment.
Should we put a UI.success call here with some nice message?
| 'demoAccountPassword' => 'Password', | ||
| 'demoAccountRequired' => false, | ||
| 'notes' => 'notes!!' | ||
| } |
There was a problem hiding this comment.
Could the pilot docs please be updated to show an example of adding these settings to your Fastfile (or however they're meant to be set). Thanks.
There was a problem hiding this comment.
Ah, scratch that, I found them.
|
Congratulations! 🎉 This was released as part of fastlane 2.28.8 🚀 |
So that we can set beta_app_feedback_email and beta_app_description
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validAdd support for setting TestFlight app-level test info. Previously we had tried to set the beta feedback email and app description through build-level test-info, but this does not work. As such, when specifying feedback email and app description through
pilot, we now set the app-level test info.