Fix accessing fastlane_core from within spaceship #9089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds tests so that never happens again
2 tasks
mpirri
reviewed
May 5, 2017
| @@ -84,15 +84,15 @@ def self.perform_for_groups_in_app(app: nil, groups: nil, &block) | |||
| if groups.nil? | |||
| default_external_group = app.default_external_group | |||
| if default_external_group.nil? | |||
| UI.user_error!("The app #{app.name} does not have a default external group. Please make sure to pass group names to the `:groups` option.") | |||
| raise "The app #{app.name} does not have a default external group. Please make sure to pass group names to the `:groups` option." | |||
There was a problem hiding this comment.
My feeling is that we need to be sure that we surface this failure as a user-error of some sort up the chain. Failing to include a group name or mistyping a group name (as in line 95 below) is not really a crash, yet if we do not rescue this error and re-raise as a user error, it will be logged as a crash by fastlane's runner.rb.
mpirri
approved these changes
May 5, 2017
Merged
|
Congratulations! 🎉 This was released as part of fastlane 2.28.9 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds tests so that never happens again
with the recent TestFlight changes, multiple
UI.somethingcalls went into spaceship causing crashes if that part of the code is reached. Currently spaceship doesn't have access to fastlane_core. I'm updating our build scripts to automatically detect those errors in the future 👍