Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note in SnapshotHelper.swift about increment the version number #9139

Merged
merged 2 commits into from May 11, 2017
Merged

Add note in SnapshotHelper.swift about increment the version number #9139

merged 2 commits into from May 11, 2017

Conversation

KrauseFx
Copy link
Member

@KrauseFx KrauseFx commented May 11, 2017 •
edited

  • Add comment to file
  • Enable it with danger too

@KrauseFx
Add note in SnapshotHelper.swift about increment the version number
5e0ceeb 
This is something we could potentially verify using danger in the future, however currently we only run danger for people with commit access
@fastlane-bot-helper
Copy link
Contributor

1 Warning
⚠️ You modified SnapshotHelper.swift, make sure to update the version number at the bottom of the file to notify users about the new helper file.

Generated by 🚫 Danger

@KrauseFx
Copy link
Member Author

Wohoo, best danger 👍

@KrauseFx
Copy link
Member Author

Note: danger works just for people with commit access

@KrauseFx KrauseFx merged commit 6be4651 into master May 11, 2017
@KrauseFx KrauseFx deleted the update-note branch May 11, 2017 14:02
@ohayon ohayon mentioned this pull request May 11, 2017
Merged
@fastlane-bot
Copy link

Hey @KrauseFx 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfurtak mfurtak mfurtak approved these changes

Assignees
No one assigned
Labels
cla: yes status: included-in-next-release tool: snapshot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KrauseFx @fastlane-bot-helper @fastlane-bot @mfurtak @googlebot