Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record scan build failures as just that rather than user_errors #9170

Merged
merged 1 commit into from May 15, 2017

Conversation

ohayon
Copy link
Contributor

@ohayon ohayon commented May 15, 2017

This is to make sure that we are recording build failures properly rather than blaming the user 馃槃

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃幏

@ohayon ohayon merged commit d5daef2 into master May 15, 2017
@ohayon ohayon deleted the scan-build-failures branch May 15, 2017 15:18
@fastlane-bot
Copy link

Hey @ohayon 馃憢

Thank you for your contribution to fastlane and congrats on getting this pull request merged 馃帀
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 馃憤
We'll notify you once we shipped a new release with your changes 馃殌

@fastlane-bot
Copy link

Congratulations! 馃帀 This was released as part of fastlane 2.31.0 馃殌

@fastlane fastlane locked and limited conversation to collaborators Aug 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants