Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched chatwork API endpoint to “v2”. #9175

Merged
merged 1 commit into from May 16, 2017

Conversation

saitomarch
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Chatwork API (v1) is no longer available since May 15 2017. (https://help.chatwork.com/hc/ja/articles/115000019401)

Description

Switched Chatwork API endpoint to "v2"

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@KrauseFx
Copy link
Member

Is the URL the only thing that needs to be changed?

@KrauseFx
Copy link
Member

Have you tried running this locally?

@saitomarch
Copy link
Contributor Author

saitomarch commented May 16, 2017

@KrauseFx

Is the URL the only thing that needs to be changed?

Yes. I've checked and it works with this change. (http://developer.chatwork.com/ja/endpoint_rooms.html#POST-rooms-room_id-messages as more information)

Have you tried running this locally?

I've tried it locally.

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks for your contribution 👍

@KrauseFx KrauseFx merged commit 6db923b into fastlane:master May 16, 2017
@fastlane-bot
Copy link

Hey @saitomarch 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.31.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants