New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched chatwork API endpoint to “v2”. #9175
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
7c6ff64
to
00b3c39
Compare
CLAs look good, thanks! |
Is the URL the only thing that needs to be changed? |
Have you tried running this locally? |
Yes. I've checked and it works with this change. (http://developer.chatwork.com/ja/endpoint_rooms.html#POST-rooms-room_id-messages as more information)
I've tried it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks for your contribution 👍
Hey @saitomarch 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.31.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Chatwork API (v1) is no longer available since May 15 2017. (https://help.chatwork.com/hc/ja/articles/115000019401)
Description
Switched Chatwork API endpoint to "v2"