Adding ability to re-send TestFlight invite to external tester #9188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added client method for API call and convenience method on Spaceship::TestFlight::Tester
hjanuschka
approved these changes
May 17, 2017
2 tasks
|
Hey @joelklabo 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Merged
|
Congratulations! 🎉 This was released as part of fastlane 2.31.0 🚀 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added client method for API call and convenience method on
Spaceship::TestFlight::Tester
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests pass (I have run the tests from the spaceship directory but the root directory tests aren't working for me. See here: Can't run tests with bundle exec rspec #9177bundle exec rubocop -ato ensure the code style is validMotivation and Context
The issue this is trying to fix is that there is no way to re-send invites to people who have already signed up with TestFlight. Issue here: #8970
In the linked issue the original report mentions that there is an API for this. So, I added the API call the the TestFlight client. I added the use of this new API to the Tester class.
New call:
Spaceship::TestFlight::Tester::resend_invitenow existsI also added a simple test.