Add a retry option on getting builds for a train #9331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ohayon
changed the title
ohayon
changed the title
KrauseFx
reviewed
Jun 1, 2017
|
Hey @ohayon 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
added
status: included-in-next-release
status: released
and removed
status: included-in-next-release
labels
|
Congratulations! 🎉 This was released as part of fastlane 2.37.0 🚀 |
1 similar comment
|
Congratulations! 🎉 This was released as part of fastlane 2.37.0 🚀 |
dvdchr
pushed a commit
to dvdchr/fastlane
that referenced
this pull request
Sep 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes intermittent 502s happen while the build watcher is waiting for the build to finish processing and show up in the list of available builds. We shouldnt fail the build watching process for that, we should just try again a couple of times to continue to wait for the build
I tested this locally but can't fudge a 500 in the middle of the waiting process, so assuming no 500's come in, this will continue to work as it always has.