Add support for Xcode 9 by automatically using the right profile for each bundle identifier #9432
Conversation
…each bundle identifier If you're using _match_ and _gym_ together with _fastlane_, you can already use Xcode 9 out of the box 🚀 I still want a fallback for this, if the user just uses gym (why would you do that even....), because right now we're failing (see #9380), instead we should try to automatically determine the profile to use based on the Xcode project settings. Using match + fastlane is the recommended way as we can be 100% certain the profiles are correct, but we should still support other ways too Kind of fixes #9380
|
Note: I don't know yet of what's the best way to receive the set provisioning profiles from the Xcode project |
fastlane/lib/fastlane/actions/gym.rb
Outdated
| values[:export_method] ||= Actions.lane_context[SharedValues::SIGH_PROFILE_TYPE] | ||
|
|
||
| if Actions.lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING] | ||
| # Since Xcode 9 you need to provide the explicit provisioning profile per app target |
There was a problem hiding this comment.
Since Xcode 9 you need to explicitly provide the provisioning profile per app target
Comment update
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@googlebot yeah, include the commit 🤦♂️ |
|
This is an awesome change 💯 |
|
Congratulations! 🎉 This was released as part of fastlane 2.38.0 🚀 |
|
Congratulations! 🎉 This was released as part of fastlane 2.38.0 🚀 |
…each bundle identifier (fastlane#9432) * Add support for Xcode 9 by automatically using the right profile for each bundle identifier If you're using _match_ and _gym_ together with _fastlane_, you can already use Xcode 9 out of the box 🚀 I still want a fallback for this, if the user just uses gym (why would you do that even....), because right now we're failing (see fastlane#9380), instead we should try to automatically determine the profile to use based on the Xcode project settings. Using match + fastlane is the recommended way as we can be 100% certain the profiles are correct, but we should still support other ways too Kind of fixes fastlane#9380 * Create gym.rb Comment update
…ile path (fastlane#9493) Fixes fastlane#9490 Introduced by fastlane#9432
If you're using match and gym together with fastlane, you can already use Xcode 9 out of the box 🚀
I still want a fallback for this, if the user just uses gym (why would you do that even....), because right now we're failing (see #9380), instead we should try to automatically determine the profile to use based on the Xcode project settings. Using match + fastlane is the recommended way as we can be 100% certain the profiles are correct, but we should still support other ways too
Fixes #9380