Pilot: Allow '~' in ipa path

[nickffox]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Fixes #9480

[ohayon]

Thanks for the PR @NicholasFFox! This is definitely a great change! I just left one comment about the methods in the IpaFileAnalyser class. Let me know what you think? 🐙

[ohayon]

Should this be happening in the methods above too? Or maybe at the call site for all of these methods?

[nickffox]

@ohayon I really wanted to make the change in fastlane_core/lib/fastlane_core/configuration/config_item.rb by changing auto_convert_value to do this:

    def auto_convert_value(value)
      return nil if value.nil?

      if data_type == Array
        return value.split(',') if value.kind_of?(String)
      elsif data_type == Integer
        return value.to_i if value.to_i.to_s == value.to_s
      elsif data_type == Float
        return value.to_f if value.to_f.to_s == value.to_s
      elsif data_type == String && allow_shell_conversion
        return value.map(&:to_s).map(&:shellescape).join(' ') if value.kind_of?(Array)
        return value.map { |k, v| "#{k.to_s.shellescape}=#{v.shellescape}" }.join(' ') if value.kind_of?(Hash)

      # new case here
      elsif data_type == String && value.include?("~/")
        return File.expand_path(value)

      else
        # Special treatment if the user specified true, false or YES, NO
        # There is no boolean type, so we just do it here
        if %w(YES yes true TRUE).include?(value)
          return true
        elsif %w(NO no false FALSE).include?(value)
          return false
        end
      end

      return value # fallback to not doing anything
    end

That fix broke a number of tests though that had ~/ in various paths, so I opted for the less global fix.

[nickffox]

@ohayon updated all methods in IpaFileAnalyser to expand paths.

[ohayon]

Hey @NicholasFFox, thanks for making those changes! And sorry I am asking one more thing, but I'm curious to hear your thoughts on the one comment I left. 💯

[ohayon]

Any chance you would want to move this into the generate method on IpaUploadPackageBuilder to let that method handle the expansion?

[nickffox]

@ohayon completely agree with the comment and made the requested change 👍

[KrauseFx]

Hey everyone, randomly jumping in here. I agree with @ohayon, this ends up with lots of duplicate code. An easy solution for that would be to do it once in gym/manager.rb right after printing the tables (as we don't necessarily want to display a really long path in the summary table) by setting it once:

Gym.config[:ipa_path] = File.expand_path(Gym.config[:ipa_path])

or similar :)

[nickffox]

@KrauseFx @ohayon - I reverted my previous changes (with the exception of the ipa parameter's verify block), and added a create_config method in Pilot's CommandsGenerator. This offers a central place to perform similar operations on Pilot parameters in the future. Does this address the previous concerns?

[KrauseFx]

Looks 💯

[nickffox]

@ohayon anything else that I need to do here?

[KrauseFx]

Thanks for reminding us @NicholasFFox, this is merged now and will be in the next release 👍 Thanks for contributing.

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.41.0 🚀