Introduce phased release to deliver #9581

giginet · 2017-06-26T05:19:19Z

Checklist

I've run bundle exec rspec from the root directory to see all new and existing tests pass
I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
I've read the Contribution Guidelines
I've updated the documentation if necessary.

Motivation and Context

I'd like to set phased release value with deliver.

Description

Added phased_release option on deliver.
phased_release API already have been supported on #9372. However, we can't use this via deliver.

giginet · 2017-06-26T05:20:53Z

deliver/Deliverfile.md

@@ -146,6 +146,16 @@ automatic_release true
 automatic_release false
 ```

+##### phased_release
+
+Should the app be phased release. If set to `true`, this update will be released over 7-day period using phased release. Default value is `false`.


Could you tell me if this sentence is strange.
I'm not a native speaker. 😅

Enable or disable the phased releases feature of iTunes Connect. If set to true, the update will be released over a 7 day period. Default value is false.

KrauseFx

Nice work 👍 This is awesome, thanks for the PR

KrauseFx · 2017-06-26T17:26:43Z

deliver/lib/deliver/options.rb

@@ -111,6 +111,10 @@ def self.available_options
                                     description: "Should the app be automatically released once it's approved?",
                                     is_string: false,
                                     default_value: false),
+        FastlaneCore::ConfigItem.new(key: :phased_release,
+                                     description: "Should the app be phased released",


Enable phased the phased release feature of iTC

KrauseFx · 2017-06-26T17:27:17Z

deliver/Deliverfile.md

@@ -146,6 +146,16 @@ automatic_release true
 automatic_release false
 ```

+##### phased_release
+
+Should the app be phased release. If set to `true`, this update will be released over 7-day period using phased release. Default value is `false`.


Enable or disable the phased releases feature of iTunes Connect. If set to true, the update will be released over a 7 day period. Default value is false.

KrauseFx · 2017-06-26T17:28:12Z

deliver/lib/deliver/upload_metadata.rb

@@ -111,6 +111,7 @@ def upload(options)
      end

      v.release_on_approval = options[:automatic_release]
+      v.toggle_phased_release(enabled: !!options[:phased_release])


What happens when phased releases are enabled on iTunes Connect, and you ship a new release using fastlane deliver with the default value?

you ship a new release using fastlane deliver with the default value?

I tried in that situation, it works well. 👍
This value might be ignored when we ship a new release.

What if:

iTunes Connect: you have phased releases enabled

deliver: You don't set anything manually and just use the default

I'd think that this would then disable phased releases on iTunes Connect, right?

In current behavior, if phased_release value is not specified on deliver, values on iTC is disabled automatically.

Do you mean If value is not specified, deliver should not change value on iTC?

giginet · 2017-06-28T09:23:17Z

deliver/lib/deliver/upload_metadata.rb

@@ -55,6 +55,8 @@ class UploadMetadata
    # Directory name it contains review information
    REVIEW_INFORMATION_DIR = "review_information"

+    # rubocop:disable Metrics/PerceivedComplexity


Do this value make sense?

https://github.com/giginet/fastlane/blob/phased-release/.rubocop.yml#L172

seems ok to me

giginet · 2017-06-28T09:25:13Z

@KrauseFx Skip toggle_phased_release when the value is not specified and I added the tests.

https://github.com/fastlane/fastlane/pull/9581/files#diff-113801503f6c061c140ffcb4f7347fa1R151

KrauseFx

Did you test this for the different use-cases?

KrauseFx · 2017-06-28T21:42:07Z

deliver/lib/deliver/upload_metadata.rb

@@ -111,6 +113,7 @@ def upload(options)
      end

      v.release_on_approval = options[:automatic_release]
+      v.toggle_phased_release(enabled: !!options[:phased_release]) unless options[:phased_release].nil?


KrauseFx · 2017-06-28T21:42:45Z

deliver/Deliverfile.md

@@ -146,6 +146,16 @@ automatic_release true
 automatic_release false
 ```

+##### phased_release
+
+Enable or disable the phased releases feature of iTunes Connect. If set to `true`, the update will be released over a 7 day period. Default value is `false`.


Default behavior is to leave whatever you defined on iTunes Connect

giginet · 2017-06-29T04:48:06Z

I tried in several situations:

Checked	new/update	Deliverfile	iTC	behavior
✅	✨ new	`true`	-	no effects
✅	⬆️ update	`true`	disabled	change to enabled
✅	⬆️ update	`false`	enabled	change to disabled
✅	⬆️ update	`nil` (not specified)	enabled	no effects(still enabled)

KrauseFx

Awesome, thanks for the update 👍

KrauseFx · 2017-06-29T20:11:41Z

Thanks @giginet 👍

taquitos · 2017-06-29T20:11:46Z

deliver/lib/deliver/options.rb

@@ -111,6 +111,11 @@ def self.available_options
                                     description: "Should the app be automatically released once it's approved?",
                                     is_string: false,
                                     default_value: false),
+        FastlaneCore::ConfigItem.new(key: :phased_release,
+                                     description: "Enable phased the phased release feature of iTC",


typo Enable the phased release feature of iTC

oops, I'll fix this on another PR 🙇

fastlane-bot · 2017-06-30T13:00:35Z

Hey @giginet 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

fastlane-bot · 2017-07-01T13:00:45Z

Congratulations! 🎉 This was released as part of fastlane 2.44.0 🚀

* Introduce phased release to deliver * Fix documents * Ignore phased_release when not specified * Add testcases for phased_release * Disable rubocop * Modify default behavior * Make optional

Introduce phased release to deliver

0a20d0e

giginet added tool: deliver type: feature labels Jun 26, 2017

giginet self-assigned this Jun 26, 2017

googlebot added the cla: yes label Jun 26, 2017

giginet commented Jun 26, 2017

View reviewed changes

giginet requested a review from KrauseFx June 26, 2017 05:27

KrauseFx reviewed Jun 26, 2017

View reviewed changes

giginet added 4 commits June 27, 2017 11:51

Fix documents

7c96495

Ignore phased_release when not specified

fefcd5e

Add testcases for phased_release

4f65e26

Disable rubocop

bb4c2e8

giginet commented Jun 28, 2017

View reviewed changes

KrauseFx reviewed Jun 28, 2017

View reviewed changes

giginet added 2 commits June 29, 2017 12:06

Modify default behavior

e0b6279

Make optional

2cf9373

KrauseFx approved these changes Jun 29, 2017

View reviewed changes

KrauseFx merged commit 279c41f into fastlane:master Jun 29, 2017

taquitos reviewed Jun 29, 2017

View reviewed changes

giginet deleted the phased-release branch June 30, 2017 04:19

d-date mentioned this pull request Jun 30, 2017

fix typo #9636

Merged

4 tasks

fastlane-bot added the status: included-in-next-release label Jun 30, 2017

KrauseFx mentioned this pull request Jun 30, 2017

Version bump to 2.44.0 #9641

Merged

fastlane-bot added status: released and removed status: included-in-next-release labels Jul 1, 2017

fastlane locked and limited conversation to collaborators Sep 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce phased release to deliver #9581

Introduce phased release to deliver #9581

giginet commented Jun 26, 2017

giginet Jun 26, 2017

KrauseFx Jun 26, 2017

KrauseFx left a comment

KrauseFx Jun 26, 2017

KrauseFx Jun 26, 2017

KrauseFx Jun 26, 2017

giginet Jun 27, 2017

KrauseFx Jun 27, 2017

giginet Jun 28, 2017

giginet Jun 28, 2017

taquitos Jun 29, 2017

giginet commented Jun 28, 2017

KrauseFx left a comment

KrauseFx Jun 28, 2017

KrauseFx Jun 28, 2017

giginet commented Jun 29, 2017 •

edited

KrauseFx left a comment

KrauseFx commented Jun 29, 2017

taquitos Jun 29, 2017

giginet Jun 30, 2017

fastlane-bot commented Jun 30, 2017

fastlane-bot commented Jul 1, 2017

Introduce phased release to deliver #9581

Introduce phased release to deliver #9581

Conversation

giginet commented Jun 26, 2017

Checklist

Motivation and Context

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KrauseFx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giginet commented Jun 28, 2017

KrauseFx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giginet commented Jun 29, 2017 • edited

KrauseFx left a comment

Choose a reason for hiding this comment

KrauseFx commented Jun 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fastlane-bot commented Jun 30, 2017

fastlane-bot commented Jul 1, 2017

giginet commented Jun 29, 2017 •

edited