Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information in docs plugin page when plugin has no GitHub URL #9633

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Add information in docs plugin page when plugin has no GitHub URL #9633

merged 1 commit into from
Jun 30, 2017

Conversation

KrauseFx
Copy link
Member

@KrauseFx KrauseFx commented Jun 29, 2017 •
edited

  • This way we show that the code might not be hosted somewhere
  • This way we kind of explain why this score is lower (e.g. we couldn't verify the README or the # of tests)

screen shot 2017-06-29 at 2 15 44 pm

@KrauseFx
Add information in docs plugin page when plugin has no GitHub URL
3d2018d 
- This way we show that the code might not be hosted somewhere
- This way we kind of explain why this score is lower (e.g. we couldn't verify the README or the # of tests)
taquitos
taquitos approved these changes Jun 29, 2017
View reviewed changes
Copy link
Collaborator

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea 🔢

@KrauseFx KrauseFx merged commit 795d707 into master Jun 30, 2017
@KrauseFx KrauseFx deleted the warn-when-no-github branch June 30, 2017 01:37
@fastlane-bot
Copy link

Hey @KrauseFx 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@KrauseFx KrauseFx mentioned this pull request Jun 30, 2017
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.44.0 🚀

dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
@KrauseFx
Add information in docs plugin page when plugin has no GitHub URL (fa…
71a511b 
…stlane#9633)

- This way we show that the code might not be hosted somewhere
- This way we kind of explain why this score is lower (e.g. we couldn't verify the README or the # of tests)
@fastlane fastlane locked and limited conversation to collaborators Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@taquitos taquitos taquitos approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KrauseFx @fastlane-bot @taquitos @googlebot