Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HockeyApp: Unknown method 'response' / To call another action from an action use other_action.response instead #9639

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

njt1982
Copy link
Contributor

@njt1982 njt1982 commented Jun 30, 2017

New Issue Checklist

Issue Description

Upgraded to the latest fastlane this morning, now hockeyapp wont deploy with this error:

[10:42:07]: --------------------
[10:42:07]: --- Step: hockey ---
[10:42:07]: --------------------
[10:42:07]: Starting with file(s) upload to HockeyApp... this could take some time.
[10:42:25]: Unknown method 'response'
+--------------------+--------------------------------------+
|                       Lane Context                        |
+--------------------+--------------------------------------+
| DEFAULT_PLATFORM   | ios                                  |
| PLATFORM_NAME      | ios                                  |
| LANE_NAME          | ios release                          |
| IPA_OUTPUT_PATH    | /Users/nthompson/Documents/react-na  |
|                    | tive/REDACTED/ios/REDACTED.i  |
|                    | pa                                   |
| DSYM_OUTPUT_PATH   | /Users/nthompson/Documents/react-na  |
|                    | tive/REDACTED/ios/REDACTED.a  |
|                    | pp.dSYM.zip                          |
| XCODEBUILD_ARCHIVE | /Users/nthompson/Library/Developer/  |
|                    | Xcode/Archives/2017-06-30/REDACTED    |
|                    | 2017-06-30 10.39.07.xcarchive        |
+--------------------+--------------------------------------+
[10:42:25]: To call another action from an action use `other_action.response` instead

+------+---------------------+-------------+
|             fastlane summary             |
+------+---------------------+-------------+
| Step | Action              | Time (in s) |
+------+---------------------+-------------+
| 1    | Verifying required  | 0           |
|      | fastlane version    |             |
| 2    | default_platform    | 0           |
| 3    | cocoapods           | 4           |
| 4    | gym                 | 184         |
| πŸ’₯   | hockey              | 18          |
+------+---------------------+-------------+

[10:42:25]: fastlane finished with errors

[!] To call another action from an action use `other_action.response` instead

Environment

βœ… fastlane environment βœ…

Stack

Key Value
OS 10.12.5
Ruby 2.2.4
Bundler? false
Git git version 2.12.2
Installation Source ~/.fastlane/bin/bundle/bin/fastlane
Host Mac OS X 10.12.5 (16F73)
Ruby Lib Dir ~/.fastlane/bin/bundle/lib
OpenSSL Version OpenSSL 1.0.2g 1 Mar 2016
Is contained false
Is homebrew true
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 8.3.3

System Locale

Variable Value
LANG en_US.UTF-8 βœ…
LC_ALL en_US.UTF-8 βœ…
LANGUAGE en_US.UTF-8 βœ…

fastlane files:

`./fastlane/Fastfile`
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://docs.fastlane.tools/actions
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "2.37.0"

default_platform :ios

platform :ios do
  before_all do
    # ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
    cocoapods
  end

  #desc "Runs all the tests"
  #lane :test do
  #  scan
  #end



  desc "Submit a new Beta Build to HockeyApp"
  lane :alpha do
    ensure_git_status_clean
    increment_build_number

    gym(
      scheme: "REDACTED",
      workspace: "REDACTED.xcworkspace",
      include_bitcode: true,
      export_method: 'enterprise'
    )

    # upload to HockeyApp
    hockey(
      api_token: ENV['HOCKEYAPP_ALPHA_API_TOKEN'],
      public_identifier: ENV['HOCKEYAPP_ALPHA_ID'],
      notify: "0",
      commit_sha: `git rev-parse HEAD`.strip
    )
  end



  desc "Submit a new Prod Build to HockeyApp"
  lane :release do
    gym(
      scheme: "REDACTED",
      workspace: "REDACTED.xcworkspace",
      include_bitcode: true,
      export_method: 'enterprise'
    )

    # upload to HockeyApp
    hockey(
      api_token: ENV['HOCKEYAPP_PROD_API_TOKEN'],
      public_identifier: ENV['HOCKEYAPP_PROD_ID'],
      notify: "0",
      commit_sha: `git rev-parse HEAD`.strip
    )
  end



  after_all do |lane|
    # This block is called, only if the executed lane was successful

    # slack(
    #   message: "Successfully deployed new App Update."
    # )
  end



  error do |lane, exception|
    # slack(
    #   message: exception.message,
    #   success: false
    # )
  end
end
`./fastlane/Appfile`
app_identifier "com.REDACTED.REDACTED" # The bundle identifier of your app
apple_id "nick@REDACTED.com" # Your Apple email address

team_id "REDACTED" # Developer Portal Team ID

# you can even provide different app identifiers, Apple IDs and team names per lane:
# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

fastlane gems

Gem Version Update-Status
fastlane 2.43.0 βœ… Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
slack-notifier 1.5.1
CFPropertyList 2.3.5
claide 1.0.1
colored2 3.1.2
nanaimo 0.2.3
xcodeproj 1.4.4
rouge 1.11.1
xcpretty 0.2.6
terminal-notifier 1.7.1
unicode-display_width 1.1.3
terminal-table 1.7.3
plist 3.2.0
public_suffix 2.0.5
addressable 2.5.1
multipart-post 2.0.0
word_wrap 1.0.0
tty-screen 0.5.0
babosa 1.0.2
colored 1.2
highline 1.7.8
commander-fastlane 4.4.5
excon 0.55.0
faraday 0.12.1
unf_ext 0.0.7.4
unf 0.1.4
domain_name 0.5.20170404
http-cookie 1.0.3
faraday-cookie_jar 0.0.6
fastimage 2.1.0
gh_inspector 1.0.3
uber 0.0.15
declarative 0.0.9
declarative-option 0.1.0
representable 3.0.4
retriable 2.1.0
mime-types-data 3.2016.0521
mime-types 3.1
little-plugger 1.1.4
multi_json 1.12.1
logging 2.2.2
jwt 1.5.6
memoist 0.15.0
os 0.9.6
signet 0.7.3
googleauth 0.5.1
httpclient 2.8.3
google-api-client 0.12.0
json 1.8.1
mini_magick 4.5.1
multi_xml 0.6.0
rubyzip 1.2.1
security 0.1.3
xcpretty-travis-formatter 0.0.4
dotenv 2.2.0
bundler 1.14.6
faraday_middleware 0.11.0.1

generated on: 2017-06-30

@njt1982
Copy link
Contributor Author

njt1982 commented Jun 30, 2017

Do I need to post the captured output too? I have to redact our client information from it...

@jonyas
Copy link

jonyas commented Jun 30, 2017

Getting exactly same error when uploading client to HockeyApp:

user_error!': [!] To call another action from an action use other_action.response instead `

Using fastlane version: 2.43.0

@gereons
Copy link

gereons commented Jun 30, 2017

Same error here, this happens during the "upload to hockeyapp" step in our fastfile. This started to fail in fastlane 2.43.0, 2.42.0 didn't have the problem.

[11:54:46]: -- Step: hockey ---
[11:54:46]: -------------------
[11:54:46]: Starting with file(s) upload to HockeyApp... this could take some time.
[11:55:09]: Unknown method 'response'
[11:55:10]: Sending crash report...

[11:55:10]: fastlane finished with errors
[!] To call another action from an action use other_action.response instead

Here's our hockey definition:

hockey(
      ipa: "./MYAPP.ipa",
      notify: "1",
      status: "2",
      notes_type: "0",
      notes: changelog_from_git_commits(pretty: "%h %s%n", commits_count: 20, merge_commit_filtering: 'exclude_merges')
    )

@njt1982
Copy link
Contributor Author

njt1982 commented Jun 30, 2017

Thank god its not just me!

Strangely, it looks like the files do actually upload! TBH I never bothered to check after seeing the error, but when I went to manually upload them I saw they were there!

@gereons
Copy link

gereons commented Jun 30, 2017

@njt1982 I just checked, and in fact the upload succeeds. Still, since the script fails, Jenkins (in my case) complains loudly that the build failed, so that's still bad.

@wgabsi88
Copy link

this error occurs also for me . this commit is the responsible 97cfb2c

@njt1982
Copy link
Contributor Author

njt1982 commented Jun 30, 2017

@wgabsi88 ah nice find - is it line 192? Where it references response in the download_url class method which has no response parameter?

@wgabsi88
Copy link

@njt1982 exactly !!!
version_url = body['public_url'] + '/app_versions/' + response.body['version']
should simply be
version_url = body['public_url'] + '/app_versions/' + body['version']

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

πŸ“ Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@njt1982
Copy link
Contributor Author

njt1982 commented Jun 30, 2017

@wgabsi88 - PR opened!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for your contribution

@KrauseFx KrauseFx merged commit f90896b into fastlane:master Jun 30, 2017
@KrauseFx KrauseFx mentioned this pull request Jun 30, 2017
@fastlane-bot
Copy link

Congratulations! πŸŽ‰ This was released as part of fastlane 2.44.0 πŸš€

dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
@fastlane fastlane locked and limited conversation to collaborators Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants