-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add param to specify keychain file location. #9703
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
Hey @ebridges, thanks for contributing, and welcome to the fastlane community. Do the |
Hi @KrauseFx as far as I can tell, the For example for a This is my rudimentary understanding based on the way that this module derives |
Is there something else I need to do -- it's not clear from the messaging above & below that I've cleared the CLA hurdles for this. Please advise thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great now, thanks @ebridges for your contribution 👍
Thanks a million @KrauseFx |
We thank you for your contribution ❤️ |
Hey @ebridges 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀 |
Fantastic thanks so much @KrauseFx 🥇 |
…action (fastlane#9703) * Add param to specify keychain file location. cf.: fastlane#9561 * Trigger CLA bot. * Trim trailing dot
cf.: #9561
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
We construct a temporary keychain file on every build and import certificates, keys etc. in order to ensure correct provisioning profiles are relied on for every build. To use the
import_certificate
command for these purposes we need to have the ability to specify the location of the keychain file.The command already relies on a variable specifying a hardcoded location of the keychain, this change simply exposes a parameter to override that location.
See issue #9561
Description
This change adds a new parameter
keychain_path
that supports overriding the built in location of the keychain path.