Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param to specify keychain file location. #9703

Merged
merged 3 commits into from
Aug 4, 2017
Merged

Add param to specify keychain file location. #9703

merged 3 commits into from
Aug 4, 2017

Conversation

ebridges
Copy link
Contributor

@ebridges ebridges commented Jul 7, 2017

cf.: #9561

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

We construct a temporary keychain file on every build and import certificates, keys etc. in order to ensure correct provisioning profiles are relied on for every build. To use the import_certificate command for these purposes we need to have the ability to specify the location of the keychain file.

The command already relies on a variable specifying a hardcoded location of the keychain, this change simply exposes a parameter to override that location.

See issue #9561

Description

This change adds a new parameter keychain_path that supports overriding the built in location of the keychain path.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@ebridges
Copy link
Contributor Author

ebridges commented Jul 7, 2017

I signed it!

@KrauseFx
Copy link
Member

KrauseFx commented Jul 7, 2017

Hey @ebridges, thanks for contributing, and welcome to the fastlane community. Do the keychain_name and the keychain_path conflict with each other?

@ebridges
Copy link
Contributor Author

ebridges commented Jul 7, 2017

Hi @KrauseFx as far as I can tell, the keychain_name refers to the name of the keychain itself vs. the path to the physical file on the filesystem.

For example for a keychain_name of login the keychain_path might be ~/Library/Keychains/login.keychain-db.

This is my rudimentary understanding based on the way that this module derives keychain_path from keychain_name in this command: FastlaneCore::Helper.keychain_path(params[:keychain_name])

@ebridges
Copy link
Contributor Author

ebridges commented Aug 4, 2017

Is there something else I need to do -- it's not clear from the messaging above & below that I've cleared the CLA hurdles for this. Please advise thanks!

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now, thanks @ebridges for your contribution 👍

@KrauseFx KrauseFx merged commit 6c74ad7 into fastlane:master Aug 4, 2017
@ebridges
Copy link
Contributor Author

ebridges commented Aug 5, 2017

Thanks a million @KrauseFx

@KrauseFx
Copy link
Member

KrauseFx commented Aug 5, 2017

We thank you for your contribution ❤️

@fastlane-bot
Copy link

Hey @ebridges 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀

@ebridges
Copy link
Contributor Author

ebridges commented Aug 9, 2017

Fantastic thanks so much @KrauseFx 🥇

@ebridges ebridges deleted the patch-1 branch August 9, 2017 00:46
dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
…action (fastlane#9703)

* Add param to specify keychain file location.

cf.: fastlane#9561

* Trigger CLA bot.

* Trim trailing dot
@fastlane fastlane locked and limited conversation to collaborators Oct 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants