Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible nil #9925

Merged
merged 2 commits into from
Aug 2, 2017
Merged

Fix possible nil #9925

merged 2 commits into from
Aug 2, 2017

Conversation

jetersen
Copy link
Contributor

@jetersen jetersen commented Aug 2, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fixes a nil error

fixes #9905

Description

to_s should convert possible nil to empty string which is good enough

Copy link
Contributor

@ohayon ohayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Casz ! Great fix! 🚀

@ohayon ohayon merged commit f39c2f0 into fastlane:master Aug 2, 2017
@ohayon ohayon mentioned this pull request Aug 2, 2017
@fastlane-bot
Copy link

Hey @Casz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀

@jetersen jetersen deleted the patch-2 branch September 3, 2017 10:17
dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
@fastlane fastlane locked and limited conversation to collaborators Nov 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Handler not protected from nil on line 238
4 participants