Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash while trying to wordwrap #9935

Merged
merged 3 commits into from
Aug 2, 2017
Merged

Fix crash while trying to wordwrap #9935

merged 3 commits into from
Aug 2, 2017

Conversation

ohayon
Copy link
Contributor

@ohayon ohayon commented Aug 2, 2017

Fix #9394

KrauseFx
KrauseFx approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

KrauseFx
KrauseFx approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ❤️

taquitos
taquitos reviewed Aug 2, 2017
View reviewed changes
fastlane_core/spec/wordwrap_spec.rb Outdated
wrap_length = 5
result = test_string.wordwrap(wrap_length)
string_lengths = result.map { |string| string.length }
expect(result).to all( be_a(String) )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not being a String an option?

Copy link
Contributor Author

@ohayon ohayon Aug 2, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really? my thought was it might be nil if the code was changed? 😄

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, you can have a nil in an array 😶

@ohayon ohayon merged commit d818862 into master Aug 2, 2017
@ohayon ohayon deleted the fix-wordwrap-crash branch August 2, 2017 19:25
@fastlane-bot
Copy link

Hey @ohayon 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@KrauseFx KrauseFx mentioned this pull request Aug 7, 2017
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀

dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
@ohayon
Fix crash while trying to wordwrap (fastlane#9935)
bd07da3
@fastlane fastlane locked and limited conversation to collaborators Oct 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@taquitos taquitos taquitos left review comments

@KrauseFx KrauseFx KrauseFx approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ohayon @fastlane-bot @KrauseFx @taquitos @googlebot