enable app_manager to delete and list app testers #9951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taquitos
commented
Aug 3, 2017
| @@ -223,7 +225,7 @@ def describe_tester(tester) | |||
| rows << ["Last name", tester.last_name] | |||
| rows << ["Email", tester.email] | |||
|
|
|||
| if tester.groups.length > 0 | |||
| if tester.groups.to_s.length > 0 | |||
There was a problem hiding this comment.
it's possible this is nil (found during testing)
2 tasks
ohayon
approved these changes
Aug 4, 2017
pilot/lib/pilot/tester_manager.rb
Outdated
| @@ -232,7 +234,7 @@ def describe_tester(tester) | |||
| rows << ["Latest Install Date", tester.pretty_install_date] | |||
| end | |||
|
|
|||
| if tester.devices.length == 0 | |||
| if tester.devices.to_so.length == 0 | |||
|
Hey @taquitos 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Merged
|
Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀 |
dvdchr
pushed a commit
to dvdchr/fastlane
that referenced
this pull request
Sep 5, 2017
* enable app_manager to delete and list app testers * Update tester_manager.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app_managers should be able to list testers and also delete them.
fix for #9910