Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to get reviews for all localisations #9968

Conversation

hhoweson
Copy link
Contributor

@hhoweson hhoweson commented Aug 4, 2017

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This allows the user to not specify the store_front (they don't have do do 155 requests per app)
fixes issue #9824

In order to test this issue I added the following code to the fastfile:

desc "Using this option you can run a user created script called test.rb which should be located in the same folder as the fastlane directory"
lane :testScript do |options|
  require "../../test.rb"
end

I then created a script called test.rb in the same place as the fastlane folder

Through that script I authenticated and then used
Spaceship::Tunes::Application.find({insert_app_code_here}).app.ratings.reviews()
to get the reviews. Note that the store_front parameter is no longer required.

Description

All changes are explained in the individual commit notes

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@hhoweson
Copy link
Contributor Author

hhoweson commented Aug 4, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 4, 2017
@KrauseFx
Copy link
Member

KrauseFx commented Aug 4, 2017

Hey @hhoweson, welcome to the fastlane community, thanks for your pull request. This looks great, would you mind updating the tests so that Circle is happy :)

@hhoweson
Copy link
Contributor Author

hhoweson commented Aug 5, 2017

@KrauseFx The issue has been addressed

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution @hhoweson ❤️

@KrauseFx KrauseFx merged commit 6428523 into fastlane:master Aug 5, 2017
@fastlane-bot
Copy link

Hey @hhoweson 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀

dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
* Added default store_front value in order to support user not specifying a store_front

* Formatting: changed order to match raw json

* Changed variable name to match repo standard

* Changed variable name to match repo standard and updated endpoint

* updated stub request url
@fastlane fastlane locked and limited conversation to collaborators Oct 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants