-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to get reviews for all localisations #9968
Added option to get reviews for all localisations #9968
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Hey @hhoweson, welcome to the fastlane community, thanks for your pull request. This looks great, would you mind updating the tests so that Circle is happy :) |
@KrauseFx The issue has been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for your contribution @hhoweson ❤️
Hey @hhoweson 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀 |
* Added default store_front value in order to support user not specifying a store_front * Formatting: changed order to match raw json * Changed variable name to match repo standard * Changed variable name to match repo standard and updated endpoint * updated stub request url
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This allows the user to not specify the store_front (they don't have do do 155 requests per app)
fixes issue #9824
In order to test this issue I added the following code to the fastfile:
I then created a script called test.rb in the same place as the fastlane folder
Through that script I authenticated and then used
Spaceship::Tunes::Application.find({insert_app_code_here}).app.ratings.reviews()
to get the reviews. Note that the store_front parameter is no longer required.
Description
All changes are explained in the individual commit notes