fix(compute/serve): output rendering #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some issues with the
compute serveoutput related to how watched files are displayed (this happened since improving the 'command output' to have boundary lines to separate it from the other contextual command information).This PR fixes those rendering/output issues but also fixes another issue I noticed related to
compute serveby reverting a change that I made recently where I moved the compilation output fromcompute buildbehind the--verboseflag (see my reasoning here: #815). Not only was this causing issues for the serve command but additionally I realised that with the new command 'boundary lines' we added it wasn't really necessary to have to hide that output any more.