Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Follow default AssemblyScript conventions for project structure. #2

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

phamann
Copy link
Member

@phamann phamann commented Oct 26, 2020

TL;DR

Restructures the project to follow AS conventions, namely use an assembly directory instead of src to house the source. Also includes the asconfig.json and assembly/tsconfig.json files to make IDEs and compilers happy based on internal user feedback.

How?

This was generated automatically using the asinit tool via npx asinit ..

Copy link
Contributor

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! 😄

My apologies for not catching this in a previous PR. I mostly use vim, so sometimes I forget all the nice stuff asinit will add for you if you are using an IDE haha 😂

@torch2424
Copy link
Contributor

Also! One thing we might want to consider is, optimizing the AssemblyScript module per how we plan on pricing C@E.

The current optimization here is the default, meant for both speed and module size. However, if we only care about speed, we may want to edit this in the future.

There is also the converge flag, which could be used to squeeze out a little bit more optimization, but in exchange for longer compilation times.

So, just calling it out now, but I think we can cross that bridge once we understand pricing a bit better, and what our customers need 😄

@phamann phamann requested a review from a team as a code owner October 26, 2020 21:37
@phamann phamann requested review from acfoltzer and cratelyn and removed request for acfoltzer October 26, 2020 21:37
Copy link

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here to affirm @torch2424's ✔️

@phamann phamann merged commit f299ada into master Oct 27, 2020
@phamann phamann deleted the phamann/as-conventions branch October 27, 2020 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants