Switch from bool to Compatibool for ACL entries
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team and
triblondon
and removed request for
a team
triblondon
approved these changes
Sep 23, 2021
This was referenced Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a breaking change, which is necessary because currently the logic is broken (e.g. passing a bool type to the API doesn't work).
NOTE: We switch the input struct types from
booltoCompatiboolwhich is a custom type with a custom implementation ofencoding.TextMarshalerandencoding.TextUnmarshaler. When coercing data back and force, theCompatibooltype, results in a boolean being changed fromfalseto0, andtrueto1. This means the request will work with our API endpoint as it expects (and returns) an integer.