Bump go-fastly to v5.0.0 to fix ACL entries bug #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team and
doramatadora
and removed request for
a team
Integralist
commented
Sep 23, 2021
| WantOutput: "Created ACL entry '456' (ip: 127.0.0.1, service: 123)", | ||
| WantOutput: "Created ACL entry '456' (ip: 127.0.0.1, negated: false, service: 123)", | ||
| }, | ||
| { |
There was a problem hiding this comment.
@doramatadora new test to validate the fix.
There was a problem hiding this comment.
otherwise I think all other changes are the generic change of path from /v4 to /v5.
Integralist
requested review from
triblondon
and removed request for
doramatadora
Integralist
force-pushed
the
integralist/gofastly-v5
branch
from
179799a
to
42277b9
Compare
triblondon
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fastly/go-fastly#307 for details.