Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go modules #325

Merged
merged 7 commits into from Jan 13, 2022
Merged

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks commented Jan 10, 2022

Just trying to update modules...

I'm updating tests in custom_tls_certificate_test as I immediately noticed that their fixtures are pretty old and the response data format is different than what we return today, and it was causing errors after updating the jsonapi module:

$ make all
==> Downloading Go module
==> Downloading development dependencies
==> Tidying module
==> Running gofmt
==> Fixing imports
==> Testing go-fastly
--- FAIL: TestClient_ListCustomTLSCertificates_validation (0.00s)
    custom_tls_certificate_test.go:145: Trying to Unmarshal an object of type "", but "tls_certificate" does not match
--- FAIL: TestClient_CustomTLSCertificate (0.00s)
    custom_tls_certificate_test.go:40: Trying to Unmarshal an object of type "", but "tls_certificate" does not match

b71bd99#diff-c0c259c2589ed26c6456d3f1a503dfad3bbf0d45a28b5ff913b90a86a687df6cL15-R15

you notice that the old fixture had an extra [{"data":{ block.

@Integralist Integralist added the enhancement New feature or request label Jan 10, 2022
@smaeda-ks smaeda-ks marked this pull request as ready for review January 13, 2022 10:56
@smaeda-ks
Copy link
Contributor Author

cc: @Integralist

@Integralist Integralist merged commit 611b86e into fastly:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants