Pagination to return interface not concrete type #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shohei Maeda <irt_m.jrsyo@ntworkers.com>
Co-authored-by: Shohei Maeda <irt_m.jrsyo@ntworkers.com>
Co-authored-by: Shohei Maeda <irt_m.jrsyo@ntworkers.com>
|
@smaeda-ks OK cool thanks. I'll merge this and I'll look at #325 (do you know if that's almost ready for a review)? |
|
@Integralist As for #325, note quite yet. Due to how go-fastly runs tests using recorded fixtures, I'm still not 100% confident to say it's okay to merge as it's not making real requests each time. So my idea is to run TF provider full tests using that branch and see if anything comes up. Since our provider is a large consumer of this library we could rely on that result relatively confidently. Thoughts? |
|
@smaeda-ks SGTM 👍🏻 OK let me know when it's ready for a review, and/or if you need any help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent pagination implementations were designed to return concrete types, which include methods attached to the returned type that in some cases are responsible for making API calls.
In the Fastly CLI we're unable to mock these returned concrete types and so in this PR I've swapped them out for interfaces.
This is a breaking change and will require a new major version of the go-fastly client.