Remove go-version #339
Merged
Remove go-version #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@meetup.com>
|
Hi @chenrui333 we were looking to deprecate this file (as we do not use it internally, as we already define the relevant supported go version within the CI configuration). Can you let me know what its/your use case is. Thanks! |
|
No use case for me, just saw this file is out of sync. |
|
Ideally, it would be nice to have such file in the repo though (kind of metadata), but yeah, it does require some sort of maintenance work (which I am happy to help with) |
|
We actually already have this information in the Thanks @chenrui333 |
|
Sounds good, let's remove it. |
Signed-off-by: Rui Chen <rui@meetup.com>
Integralist
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.