Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI support for an optional ,interval for the guest profiler, to match wasmtime #357

Open
katef opened this issue Apr 9, 2024 · 0 comments
Open

CLI support for an optional ,interval for the guest profiler, to match wasmtime #357

katef opened this issue Apr 9, 2024 · 0 comments
Labels
feature-ux Concerning ergonomics and ease-of-use good first issue Good for newcomers

Comments

@katef
Copy link
Contributor

katef commented Apr 9, 2024

In #301 support for guest profiling was added. This corresponds to an equivalent CLI flag in wasmtime introduced in bytecodealliance/wasmtime#6362 (and documented in bytecodealliance/wasmtime#6393).

We have no way to control the profiling interval for Viceroy:

Viceroy: --profile=guest[,path]
Wasmtime: --profile=guest[,path[,interval]]

This ticket is to add the optional ,interval part, just like wasmtime has.
@katef katef added feature-ux Concerning ergonomics and ease-of-use good first issue Good for newcomers labels Apr 9, 2024
@fgsch fgsch mentioned this issue Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-ux Concerning ergonomics and ease-of-use good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katef