Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasmtime* crates to 19.0.2 #361

Closed
wants to merge 1 commit into from
Closed

Update wasmtime* crates to 19.0.2 #361

wants to merge 1 commit into from

Conversation

fgsch
Copy link
Member

@fgsch fgsch commented Apr 16, 2024

I wanted to have an idea of how much effort, at least superficially, was required to update Viceroy.
The tests are passing but beyond that this is mostly mechanical and untested.

Addresses #360 and I believe is required for #357.

Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the guest-profiler change here is valid: there's an opportunity to collect more data and produce even more useful profiles, but as written this PR preserves the existing behavior, which is good enough.

I'm less sure about switching from wasmtime-wasi to wasi-common. My impression is that wasi-common is becoming deprecated, but I'm not certain of that.

@jameysharp
Copy link
Contributor

Oh, and if we want to note anything about user-visible changes in Viceroy release notes, upgrading to Wasmtime 18 or newer gets us name demangling in guest-profiler output, which is a nice quality of life improvement when profiling Rust services especially.

@fgsch
Copy link
Member Author

fgsch commented Apr 22, 2024

[..]
I'm less sure about switching from wasmtime-wasi to wasi-common. My impression is that wasi-common is becoming deprecated, but I'm not certain of that.

Thanks for having a look. I will check this and update the PR accordingly.

@elliottt
Copy link
Contributor

elliottt commented May 7, 2024

Do you mind if we close this in favor of #366? I've made the wasmtime-wasi switch in that PR as well.

@fgsch
Copy link
Member Author

fgsch commented May 8, 2024

Closed in favour of #366

@fgsch fgsch closed this May 8, 2024
@fgsch fgsch deleted the fgsch/wasmtime-19 branch May 8, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants