Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STL vector to nnet_helpers.h #307

Merged

Conversation

ConsVin
Copy link
Contributor

@ConsVin ConsVin commented Mar 23, 2021

Issue

Vivado 2020.2 removed vivado_hls tool and now supports only vitis_hls
https://www.xilinx.com/support/documentation/sw_manuals/xilinx2020_2/ug973-vivado-release-notes-install-license.pdf

This release introduces the new HLS product with support for both Vitis™ and Vivado®. As part of this the overall folder structure changes, whereby the Vitis_HLS folder is now at the same root location as Vivado® and Vitis™. You may need to update any custom setup scripts from the previous release.

But HLS project build with vitis_hls

/tools/Xilinx/Vitis_HLS/2020.2/bin/vitis_hls  -f build_prj.tcl "reset=1 csim=1 synth=1 cosim=1 validation=1 export=1 vsynth=0"

Fails due to missed <vector> header:

***** C/RTL SYNTHESIS *****
INFO: [HLS 200-1510] Running: csynth_design 
INFO: [HLS 200-111] Finished File checks and directory preparation: CPU user time: 0.01 seconds. CPU system time: 0.01 seconds. Elapsed time: 0.01 seconds; current allocated memory: 223.149 MB.
INFO: [HLS 200-10] Analyzing design file 'firmware/hls4ml_arcas.cpp' ... 
ERROR: [HLS 214-125] no member named 'vector' in namespace 'std': ../hls_project/firmware/nnet_utils/nnet_helpers.h:279

Proposed PR adds missed header

@KOVI89alipes
Copy link
Contributor

@thesps :)

@vloncar
Copy link
Contributor

vloncar commented Aug 12, 2021

This is handy for compiling with external compilers but not that it doesn't really make the hls4ml compatible with Vitis HLS. A lot of work still needs to happen for that.

@vloncar vloncar merged commit dca8348 into fastmachinelearning:master Aug 12, 2021
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
Co-authored-by: Konstantin Vinogradov <konstantin.vinogradov@alipescapital.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants