Don't override precision directly in the QKeras optimizer #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you push to a local branch to trigger the Gitlab CI? The convention so far has been to push to, in the case, |
thesps
approved these changes
Jun 15, 2022
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output_rounding_saturation_modeoptimizer directly manipulates precision object of the output variable of the node, which can trip up the later optimizers and make them skip the type conversion. It was observed in testing of accelerator backend with fifo depth optimization (by @thesps) as well as some GNN models (by @sznajder) This change ensures the update of precision also updates the entire type. Eventually we will make theprecisiona read-only property to ensure this type of error doesn't affect future optimizers, but this kind of change requires a bit more work.